QAM public cloud enablement #8422

pdostal · 2019-09-11T12:22:01Z

Related ticket: poo#54842
Needles: os-autoinst-needles-sles#1231
Verification run: latest

pdostal · 2019-09-11T15:04:51Z

tests/publiccloud/qam_init.pm

pevik

LGTM. I'd just describe a bit goals of QAM tests (I guess it's the concentration on user space; I mean there is lot's of files named qam, but no explanation in the commit message).

asmorodskyi · 2019-09-12T08:28:31Z

LGTM. I'd just describe a bit goals of QAM tests (I guess it's the concentration on user space; I mean there is lot's of files named qam, but no explanation in the commit message).

+1 to this . there is no such thing us "QAM test" , there is just a test which would be executed by someone . Test should say what it actually tests and not who is executing it

pdostal · 2019-09-12T09:33:14Z

LGTM. I'd just describe a bit goals of QAM tests (I guess it's the concentration on user space; I mean there is lot's of files named qam, but no explanation in the commit message).

+1 to this . there is no such thing us "QAM test" , there is just a test which would be executed by someone . Test should say what it actually tests and not who is executing it

I agree as well 😄 I will rename it properly.

The purpose of this is to allow us to run existing tests on public cloud.

Currently I use user-console create instance and open SSH tunnel for /dev/sshserial.
Then I switch to root-console and I open interactive SSH session there.
This 'hack' allows me to include existing tests so they continue in the SSH session from 2)
At the end I just destroy the public cloud VM

My idea is to move the logic from user-console to new-separate console, but I don't know how...

cfconrad · 2019-09-12T09:54:01Z

My idea is to move the logic from user-console to new-separate console, but I don't know how...

I had a conversation with @okurz about such solution in the past. And if I'm not wrong he worked on something similar. Can you comment plz?

pdostal · 2019-09-12T10:27:06Z

LGTM. I'd just describe a bit goals of QAM tests (I guess it's the concentration on user space; I mean there is lot's of files named qam, but no explanation in the commit message).

I renamed it to ssh_init and ssh_end perhaps it opens the SSH interactive session.
I kept the qam_test because it has no future and is less selfish than pdostal_test 😄

cfconrad

Looks nice.
The VR didn't point to explicit job, can you point to one using the latest code?

tests/publiccloud/ssh_init.pm

tests/publiccloud/qam_test.pm

tests/publiccloud/ssh_end.pm

pdostal · 2019-09-16T10:37:31Z

@cfconrad as #8439 is already merged I just force-pushed a new code, where I use $instance->run_ssh_command() but please see lib/publiccloud/instance.pm because of I needed to use script_run() instead of script_output() so I added another argument but the default behavior is still the same.

lib/publiccloud/instance.pm

lib/main_common.pm

lib/publiccloud/basetest.pm

cfconrad

Beside this test_flags() overwrite, everything looks good to me.

lib/consoletest.pm

tests/publiccloud/download_repos.pm

cfconrad

nice! Let's see how it run :)

asmorodskyi · 2019-10-10T13:42:33Z

tests/publiccloud/instance_overview.pm

@@ -0,0 +1,49 @@
+# SUSE's openQA tests


@cfconrad , I have a feeling that we already have all or most part of this info somewhere ? img_proof tests ? or we gathering this info somewhere ? terraform output ?

This whole test is actually not a test but bunch of commands I used to proof that the SSH console works. I would personally keep it just to see something basic at the beginning but we can remove it as well...

@asmorodskyi you are right that img_proof collects some of it and so on. But I actually don't know if QAM team will run img_proof at all. From what I see currently, they are using a different approach to run openQA modules on the instance. I would keep it as well.

asmorodskyi · 2019-10-10T13:43:42Z

tests/publiccloud/instance_overview.pm

+
+    assert_script_run("ps aux | nl");
+
+    register_product();


this might behave differently based on type of image you use , so bad idea use it unconditionally

How do you mean that? I just want to install traceroute

Some of images available in Public Cloud expecting something like this - they called BYOS - there you getting unregistered image which suppose to register . But others will give you image which already registered via Public Cloud Provider so you don't need to register it and can just use it. Not sure how this type of images will react on attempt to register them via SCC ...

Now I see, well, I would wait with this. Currently I use only one image and nobody decided yet for which images this will be used. The goal for this pull request is to enable the interactive ssh console in the public cloud environment. After that I will be dealing with individual tests and scenarios.

tests/publiccloud/path_and_reboot.pm

lib/y2_module_consoletest.pm

asmorodskyi · 2019-10-10T14:12:52Z

tests/publiccloud/transfer_repos.pm

+    select_console 'root-console';
+
+    assert_script_run("rsync -va -e ssh ~/repos root@" . $args->{my_instance}->public_ip . ":'/tmp/repos'", timeout => 900);
+    $args->{my_instance}->run_ssh_command(cmd => "sudo find /tmp/repos/ -name *.repo -exec sed -i 's,http://,/tmp/repos/repos/,g' '{}' \\;");


you actually connecting as root user , why you do everything via sudo ?

I don't. The default user is ec2-user.

okurz

The approach in general looks ok. I have not found any serious flaws. However there is a bit of duplication related to #8099 . Please take a look into there for my approach, maybe you find it helpful.

pdostal · 2019-10-11T06:46:13Z

However there is a bit of duplication related to #8099 . Please take a look into there for my approach, maybe you find it helpful.

Hello @okurz, I tried some of the code from #8099 before, but yesterday, when I saw it all in one PR I managed to actually execute it and implement our use case into it.

Can I ask you to take a look once more?

cfconrad

Latest changes with TUNNELED approach looking good to me!

okurz · 2019-10-11T16:56:04Z

yep, I like it as well. Nicely done. Something similar as in https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/Remote/Lab.pm#L66 might be helpful as well but it's not mandatory.

pdostal · 2019-10-12T04:22:11Z

@okurz thank you very much.

Something similar as in https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/Remote/Lab.pm#L66 might be helpful as well but it's not mandatory.

There is ssh_interactive_tunnel() in lib/publiccloud/ssh_interactive.pm which I find similar to your setup_ssh_tunnels(). The reason why I didn't reuse it is because I found it too specific for your scenario. For example I don't have any jumphost.

okurz · 2019-10-12T17:38:18Z

sure, of course. I did not think it is "reusable", just could provide ideas.

pdostal force-pushed the qampc1 branch 2 times, most recently from d3e1500 to 522b04c Compare September 11, 2019 15:02

pdostal force-pushed the qampc1 branch 2 times, most recently from be4ad66 to 71a0594 Compare September 12, 2019 07:14

asmorodskyi reviewed Sep 12, 2019

View reviewed changes

tests/publiccloud/qam_init.pm Outdated Show resolved Hide resolved

pevik approved these changes Sep 12, 2019

View reviewed changes

pdostal force-pushed the qampc1 branch from 71a0594 to d2f0e32 Compare September 12, 2019 10:24

pdostal force-pushed the qampc1 branch 3 times, most recently from 1360dd9 to a5121e2 Compare September 12, 2019 11:38

cfconrad reviewed Sep 12, 2019

View reviewed changes

pdostal force-pushed the qampc1 branch 2 times, most recently from 47092a1 to 899ca7d Compare September 12, 2019 20:50

pdostal mentioned this pull request Sep 12, 2019

publiccloud: Add single quote to run_ssh_command() #8439

Merged

pdostal force-pushed the qampc1 branch 2 times, most recently from c53df18 to 2c4835e Compare September 16, 2019 10:28

pdostal force-pushed the qampc1 branch from 2c4835e to 9efb490 Compare September 23, 2019 08:47

cfconrad mentioned this pull request Sep 23, 2019

Add SLES4SAP tests on Public Cloud #8483

Merged

asmorodskyi reviewed Sep 24, 2019

View reviewed changes

lib/publiccloud/instance.pm Outdated Show resolved Hide resolved

asmorodskyi reviewed Sep 24, 2019

View reviewed changes

lib/main_common.pm Outdated Show resolved Hide resolved

asmorodskyi reviewed Sep 24, 2019

View reviewed changes

lib/main_common.pm Outdated Show resolved Hide resolved

asmorodskyi reviewed Sep 24, 2019

View reviewed changes

lib/publiccloud/basetest.pm Show resolved Hide resolved

pdostal force-pushed the qampc1 branch 2 times, most recently from 28fd7f6 to cdf6356 Compare October 2, 2019 09:11

pdostal force-pushed the qampc1 branch 2 times, most recently from e0c5b31 to 110593e Compare October 10, 2019 12:12

cfconrad requested changes Oct 10, 2019

View reviewed changes

lib/consoletest.pm Outdated Show resolved Hide resolved

tests/publiccloud/download_repos.pm Outdated Show resolved Hide resolved

pdostal force-pushed the qampc1 branch 3 times, most recently from 0d45e46 to 5b5ebba Compare October 10, 2019 13:18

cfconrad approved these changes Oct 10, 2019

View reviewed changes

asmorodskyi reviewed Oct 10, 2019

View reviewed changes

tests/publiccloud/path_and_reboot.pm Outdated Show resolved Hide resolved

pdostal force-pushed the qampc1 branch from 5b5ebba to a923028 Compare October 10, 2019 13:52

rwx788 reviewed Oct 10, 2019

View reviewed changes

lib/y2_module_consoletest.pm Outdated Show resolved Hide resolved

asmorodskyi reviewed Oct 10, 2019

View reviewed changes

okurz reviewed Oct 10, 2019

View reviewed changes

pdostal force-pushed the qampc1 branch from a923028 to 6bf277b Compare October 11, 2019 04:47

pdostal force-pushed the qampc1 branch 4 times, most recently from 5a6b408 to 341ab8b Compare October 11, 2019 09:28

QAM public cloud enablement

5249a7a

pdostal force-pushed the qampc1 branch from 341ab8b to 5249a7a Compare October 11, 2019 09:45

cfconrad approved these changes Oct 11, 2019

View reviewed changes

okurz approved these changes Oct 12, 2019

View reviewed changes

asmorodskyi approved these changes Oct 14, 2019

View reviewed changes

cfconrad merged commit 7c3f7ac into os-autoinst:master Oct 14, 2019

pdostal deleted the qampc1 branch December 28, 2022 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QAM public cloud enablement #8422

QAM public cloud enablement #8422

pdostal commented Sep 11, 2019 •

edited

pdostal commented Sep 11, 2019 •

edited

pevik left a comment

asmorodskyi commented Sep 12, 2019

pdostal commented Sep 12, 2019

cfconrad commented Sep 12, 2019

pdostal commented Sep 12, 2019

cfconrad left a comment

pdostal commented Sep 16, 2019

cfconrad left a comment

cfconrad left a comment

asmorodskyi Oct 10, 2019

pdostal Oct 10, 2019

cfconrad Oct 10, 2019

asmorodskyi Oct 10, 2019

pdostal Oct 10, 2019

asmorodskyi Oct 10, 2019

pdostal Oct 10, 2019

asmorodskyi Oct 10, 2019

pdostal Oct 10, 2019

okurz left a comment

pdostal commented Oct 11, 2019

cfconrad left a comment

okurz commented Oct 11, 2019

pdostal commented Oct 12, 2019

okurz commented Oct 12, 2019

QAM public cloud enablement #8422

QAM public cloud enablement #8422

Conversation

pdostal commented Sep 11, 2019 • edited

pdostal commented Sep 11, 2019 • edited

pevik left a comment

Choose a reason for hiding this comment

asmorodskyi commented Sep 12, 2019

pdostal commented Sep 12, 2019

cfconrad commented Sep 12, 2019

pdostal commented Sep 12, 2019

cfconrad left a comment

Choose a reason for hiding this comment

pdostal commented Sep 16, 2019

cfconrad left a comment

Choose a reason for hiding this comment

cfconrad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okurz left a comment

Choose a reason for hiding this comment

pdostal commented Oct 11, 2019

cfconrad left a comment

Choose a reason for hiding this comment

okurz commented Oct 11, 2019

pdostal commented Oct 12, 2019

okurz commented Oct 12, 2019

pdostal commented Sep 11, 2019 •

edited

pdostal commented Sep 11, 2019 •

edited